rymghosn commented on PR #6255: URL: https://github.com/apache/fineract/pull/6255#issuecomment-5992513504
@adamsaghy A small follow-up so that this PR and #6282 work in either merge order: the checker-only refusal (`error.msg.maker.checker.checker.only.cannot.initiate`) now applies only when **no identical submission is pending**, using the same key as the duplicate check. When one is pending, #6282 lets the call approve it. Without #6282, the call falls through to the existing permission check. A unit test covers both cases, and the integration test now sends the checker-only request with a different payload. The full `MakercheckerTest` class still passes on PostgreSQL, and the description is updated. Could you please re-review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
