rymghosn opened a new pull request, #6583: URL: https://github.com/apache/fineract/pull/6583
## Description JIRA: [FINERACT-2893](https://issues.apache.org/jira/browse/FINERACT-2893) Updating a client family member's relationship (`PUT /clients/{clientId}/familymembers/{familyMemberId}` with a new `relationshipId`) returned 200 but left the relationship unchanged. **Root cause:** `ClientFamilyMemberCommandFromApiJsonDeserializer` only supports `relationshipId`, and add-member and create-client-with-family-members read that key. `ClientFamilyMembersWritePlatformServiceImpl.updateFamilyMember` read the misspelled `relationShipId`, so the value was ignored. Sending `relationShipId` instead is rejected as an unsupported parameter, so no payload could change the relationship. **Fix:** - `updateFamilyMember` reads `relationshipId`. - `validateForCreate(long, String)` and `validateForUpdate` use the existing `RELATIONSHIP_ID` constant. - The misspelled `RELATION_SHIP_ID` constant is removed. **Tests:** new unit test `ClientFamilyMembersWritePlatformServiceImplTest.updateFamilyMemberAppliesRelationshipId`. It fails on current `develop` and passes with this change. `spotlessJavaCheck` passes. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes. _No API change: the documented `relationshipId` parameter now works on update._ - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
