jenny1371 opened a new pull request, #6587:
URL: https://github.com/apache/fineract/pull/6587

   ## Description
   
   FINERACT-2829 reports that the roles OpenAPI response is missing a `status` 
field for `/system/roles-and-permissions`.
   That path does not exist, and the roles responses contain no `status`. The 
real responses (`GET /roles`, `GET /roles/{id}`, `GET /roles/{id}/permissions`) 
return `"disabled": true|false` (from `RoleData` / `RolePermissionsData`), 
which the OpenAPI classes did not declare.
   
   This adds `Boolean disabled` to `GetRolesResponse`, `GetRolesRoleIdResponse` 
and `GetRolesRoleIdPermissionsResponse`. Documentation-only: no behaviour 
change.
   
   Verified against a running instance built from `develop` (4684c66) and with 
`./gradlew :fineract-provider:spotlessCheck :fineract-provider:compileJava` on 
JDK 25.
   
   ## Checklist
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [ ] Create/update unit or integration tests for verifying the changes 
made. _(OpenAPI documentation classes only; no behaviour to test.)_
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation _(Swagger 
annotations added; legacy apiLive.htm not touched.)_
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 _(6 lines, 1 file.)_
   - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately. _(My ASF JIRA account is 
pending; a committer may need to do this.)_
   - [x] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
 _(Generative AI assisted; disclosed with an `Assisted-By` trailer in the 
commit.)_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to