rk-roshan-kr opened a new pull request, #723:
URL: https://github.com/apache/fineract-backoffice-ui/pull/723
## Description
Closes #452.
This PR completes the migration of all remaining feature and shared
components to the `I18N` adapter boundary (`src/app/core/adapters`), removing
all remaining direct `@ngx-translate/core` imports outside of the adapter
implementation (`src/app/core/adapters/i18n`), application bootstrap config
(`src/app/app.config.ts`), and testing harness
(`src/app/testing/i18n-testing.ts`).
### Summary of Changes
1. **Component and Template Migration**:
- Replaced direct `@ngx-translate/core` imports (`TranslatePipe`,
`TranslateService`) with `I18N` and `TranslatePipe` from `core/adapters`.
- Replaced template `| translate` pipe usages with the adapter-backed `|
appTranslate` pipe across 27 feature and shared files.
- Updated component imperative translation calls
(`this.translate.instant(...)`, `this.translate.get(...)`,
`this.translate.use(...)`) to use `this.i18n.translate(...)`,
`this.i18n.translateAsync(...)`, and `this.i18n.use(...)`.
- Cleaned up duplicate/unused `NgxTranslatePipe` imports in
`client-form`, `loan-schedule-modify`, and `audit-logs-list`.
2. **ESLint Suppression Ratchet**:
- Pruned retired `no-restricted-imports` suppressions in
`eslint-suppressions.json` across all migrated files.
3. **Verification**:
- All 293 test suites (2042 unit tests) pass without regression.
- `npm run lint` passes with 0 errors.
- `npm run i18n:check` passes (no missing keys, 100% consistent
catalogues).
- `npm run test:eslint-rules` and `npm run test:scripts` pass (78 tests
total).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
