rymghosn opened a new pull request, #6611: URL: https://github.com/apache/fineract/pull/6611
## Description JIRA: [FINERACT-2905](https://issues.apache.org/jira/browse/FINERACT-2905) An action blocked by an Entity Data Table Check returned: ``` The datatable [X] needs to be filled in before the current action can be proceeded ``` The sentence is ungrammatical and does not say which action or entity is blocked, although both `EntityDatatableChecksWritePlatformServiceImpl.runTheCheck` and `runTheCheckForProduct` know the entity and the status being checked. `DatatableEntryRequiredException` gets a constructor taking the datatable names, the entity name and the status, used by both checks. It builds `Please fill in the data table [X] before approving this loan.`: the verb comes from `StatusEnum`, the noun from `EntityTables.getHumanReadableName()`, and the plural is used for several tables. It falls back to `... before continuing.` when the entity or status is unknown. The error code `error.msg.entry.required.in.datatable.[X]` and its argument are unchanged, so clients that translate by code keep working. (The other two issues originally listed on FINERACT-2905 are covered by FINERACT-2904 / #6609. This PR touches none of #6609's files.) **Tests** - `DatatableEntryRequiredExceptionTest` (unit, 4 tests): single and plural messages, several entity/status pairs, and the fallback. It does not compile against `develop`, because the constructor is new. - Live red/green on a local boot against PostgreSQL, with a CREATE check on `m_group` and an APPROVE check on `m_loan`: - `develop`: `POST /groups` and `POST /loans/{id}?command=approve` both return 403 "The datatable [X] needs to be filled in before the current action can be proceeded". - this branch: 403 "Please fill in the data table [X] before creating this group." and "Please fill in the data table [X] before approving this loan.", with the same error code, and the loan stays pending. With the datatable entries supplied, both calls return 200. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
