pranavdhanabalan opened a new pull request, #735:
URL: https://github.com/apache/fineract-backoffice-ui/pull/735
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Commits must be signed to merge — see CONTRIBUTING.md#commit-signing if
you haven't set this up. -->
<!--
New feature, or a change to how a screen works?
Apache Fineract decides those on its developer mailing list, not in a pull
request. A PR
that arrives with a thread behind it is reviewed on its merits; one that
proposes something
nobody has seen spends its first round of review on the proposal instead
of the code.
Subscribe [email protected] (blank email)
Post [email protected]
Archive https://lists.apache.org/[email protected]
Chat https://matrix.to/#/%23apache-fineract-dev:matrix.org
Bug fixes, refactors and test work need none of this — open away.
-->
## What and why
<!-- One or two sentences explaining what changed and why. -->
Configured sidebar navigation links to use exact route matching for the
active state because partial matching could highlight a parent menu item on
nested routes, making the current page unclear.
Closes #734
## Verification
<!-- List what you ran and what you checked. Note whether the UI was
exercised with mocks, a real Fineract backend, or both. -->
-npm run lint
-npm run format:check
## Screenshots
<!-- Add screenshots or a short recording for UI changes. Write "Not
applicable" for non-UI changes. -->
<img width="2940" height="1686" alt="image"
src="https://github.com/user-attachments/assets/309f3e00-8f1b-4bd3-9083-6560a9166b1e";
/>
## Checklist
<!-- Check each item, or explain why it does not apply. -->
- [X] I did not hand-edit generated files under `src/app/api/`.
- [X] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs.
- [X] User-facing strings use translation keys.
- [X] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [X] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant.
- [X] Commits are signed — see [Commit
Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md.
- [X] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
- [X] If this adds a feature or changes a workflow, I raised it on
[[email protected]](https://lists.apache.org/[email protected])
first —
or it is a bug fix, refactor or test change, where that does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
