1cbyc opened a new pull request, #202: URL: https://github.com/apache/fineract-consumer-facing/pull/202
## What changed and why Migrates the complete loans area behind the application's I18N adapter, as requested in #177: - imports `TranslatePipe` from `core/adapters` in all five loans components - renames their template usages to `appTranslate` - switches the loan application and repayment specs to `provideI18nTesting()` - prunes all seven loans entries from the ESLint suppression baseline This keeps translation behavior unchanged while removing the loans feature's direct dependency on ngx-translate. Closes #177 Part of #172 ## Verification - `npm test -- --no-watch --include src/app/features/loans/loan-apply.component.spec.ts --include src/app/features/loans/loan-repay.component.spec.ts` (24 passed) - `npm test -- --no-watch` (24 files, 144 tests passed) - `npm run lint:prune` - `npm run lint` - `npm run i18n:check` - `npx prettier --check src/app/features/loans eslint-suppressions.json` - `npm run build` - `git diff --check` ## Checklist - [x] I did not hand-edit generated files under `frontend/src/openapi-client/`. - [x] Frontend code goes through the adapters in `frontend/src/app/core/adapters/`. - [x] I did not add entries to a lint or architecture baseline to get the build passing. - [x] User-facing strings use translation keys. - [x] Existing component tests cover the migrated application and repayment screens. - [x] No UI workflow behavior changed, so no new e2e coverage is needed. - [x] Commits are signed. - [x] I followed the repository contribution guidance. - [x] This is a refactor and does not require a developer mailing-list proposal. Co-authored-by: insisong <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
