KRYSTALM7 commented on PR #169: URL: https://github.com/apache/fineract-loan-origination/pull/169#issuecomment-6122613046
Good job @priyam99! The description is clean and easy to follow. Leaving the terminal states (REJECTED, DISBURSED) on the IllegalStateException handler is the right call, and the sanity check of removing the handler to see the tests fail with 500 is a nice touch. Partially approved from my side. @Aman-Mittal once we get the curl command output or image, I think we can merge this. @priyam99 also, please join the dev mailing list or the Matrix channel so you can DM us directly whenever a review is needed on your PRs. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
