adamsaghy commented on PR #6285: URL: https://github.com/apache/fineract/pull/6285#issuecomment-6128705541
@rymghosn Please review the below findings: - **Double tax:** develop already records taxDetails on every loan charge through applyTaxIfConfigured. On every charge payment it splits the tax out pro-rata (LoanJournalEntryPosterImpl.java:195-206), and accounting nets it out of fee income. This applies to every payment path, not just disbursement. The PR adds tax on top of amountOutstanding again, including at disbursement, the case it says already worked. - the transaction amount is now base + tax, but the processor only pays the fee portion, so the extra goes to onLoanOverpayment and becomes a credit balance instead of tax. - in the disbursement repayment, the fee portion is base + tax while markAsFullyPaid records only the base, so the summary is likely inconsistent. - No tests for the new behaviour. - The description is stale. calculateChargeAmountWithTax is described as already existing, but it’s new in this PR, and getApplicableTaxComponentSummaries has been removed. - This PR conflicts with #6237 over the same new TaxUtils method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
