adamsaghy commented on PR #6288: URL: https://github.com/apache/fineract/pull/6288#issuecomment-6128785752
@rymghosn Please review the below concerns: - the claim “start date can only change to a date strictly after today” isn’t enforced. validateDateAfter(today) accepts today itself (DataValidatorBuilder.java:1025). - the lock uses parameterExists, not “changed”. A PUT that resends the current percentage or accounts is rejected, so a client that sends the whole form can’t rename an in-use component. - GL account fields on update get no validation (type range, id > 0, type/id pairing), unlike on create. An unknown type silently becomes null. - moving a future start date later without a percentage change writes no history row, which could leave a gap in getApplicablePercentage. - There are no tests at all, and the Swagger model doesn’t include accountsEditable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
