ayushcodes27 opened a new pull request, #203:
URL: https://github.com/apache/fineract-consumer-facing/pull/203
## What and why
Part of #172. Fixes #180.
Migrates `RegistrationComponent` template and unit tests away from direct
`@ngx-translate/core` imports to the `appTranslate` adapter pipe
(`TranslatePipe`) and `provideI18nTesting()` test helper, and prunes the
corresponding suppression entries from `frontend/eslint-suppressions.json`.
## Verification
- `npm run lint` passed (0 errors).
- `npm run lint:prune` removed the 2 registration suppression entries
cleanly.
- `npm test -- --include
src/app/features/registration/registration.component.spec.ts` passed (12 of 12
tests passing).
- `npm run i18n:check` passed (no hardcoded user-facing strings).
- `npm run build` completed successfully with zero template compilation
errors.
## Screenshots
Not applicable (internal refactor preserving identical UI rendering).
## AI assistance (optional)
- Tool / model: Gemini, Claude
- Harness / workflow: Verification and Review
## Checklist
- [x] I did not hand-edit generated files under
`frontend/src/openapi-client/`.
- [x] Backend code follows the feature and CQRS layout in
[AGENTS.md](AGENTS.md#backend-conventions-consumer) (command and query sides,
module boundaries); frontend code goes through the adapters in
`frontend/src/app/core/adapters/`.
- [x] I did not add entries to a lint or architecture baseline
(suppressions, frozen violations) to get the build passing.
- [x] User-facing strings use translation keys.
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [x] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant.
- [x] Commits are signed — see [Signing your
commits](CONTRIBUTING.md#signing-your-commits) in CONTRIBUTING.md.
- [x] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
- [x] If this adds a feature or changes what a consumer can see or do, I
raised it on
[[email protected]](https://lists.apache.org/[email protected])
first,
or it is a bug fix, refactor or test change, where that does not apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
