somasorosdpc opened a new pull request, #6624:
URL: https://github.com/apache/fineract/pull/6624

   ## Description
   
   ### Adjust trn with Payment type specified on regular loan outcomes with 403 
Forbidden error
   
   Steps to reproduce:
   
   -  create loan account within any progressive loan product, approve and 
disburse
   - add repayment transaction
   - on Transaction tab for Repayment transaction select an option Adjust and 
populate it with required data(date, amount) and ‘Payment Type’
   
   Expected result:
   Adjust processed successfully with no error
   
   Actual result:
   403 Forbidden error is shown with error message:
   
   ```
   defaultUserMessage: "During synchronization a new object was found through a 
relationship that was not marked cascade PERSIST: 
org.apache.fineract.portfolio.paymentdetail.domain.PaymentDetail@5ef0a669."
   developerMessage: "The request caused a data integrity issue to be fired by 
the database."
   userMessageGlobalisationCode: "error.msg.data.integrity.issue"
   ```
   
   ### Changes:
   
   * end-to-end test case to reproduce the issue.
   * added persist call on repository to avoid data integrity issue
   * added step def to test adjust transaction feature
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   - [x] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately.
   - [x] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to