samchinmaya opened a new pull request, #6628: URL: https://github.com/apache/fineract/pull/6628
## Description JIRA: [FINERACT-2917](https://issues.apache.org/jira/browse/FINERACT-2917) (follow-up to #6627, as discussed with @IOhacker) `MeetingAttendanceUpdateRequest.meetingAttendance` was annotated `@Hidden`, so the OpenAPI specification documented only `id` and `attendanceType` for `POST /{entityType}/{entityId}/meetings/{meetingId}?command=saveOrUpdateAttendance`. The generated `fineract-client` therefore had no way to send the attendance list. This PR removes `@Hidden` from `meetingAttendance`. Comparing the generated `fineract.json` before and after, the only change is one added optional property, `meetingAttendance` (an array of `MeetingAttendanceData`). `id` and `attendanceType` are unchanged, so the API stays backward compatible. The legacy `apiLive.htm` documents the list as `clientsAttendance`, which works since #6627 through `@JsonAlias`, so it needs no change. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
