adamsaghy commented on PR #6595: URL: https://github.com/apache/fineract/pull/6595#issuecomment-6189064717
@Abhishek6122008 Can you please review my below concern? **It doesn’t check that parts are reachable from db.changelog-master.xml.** It only checks that some file with an <include> lists each part. If an include for a whole module’s changelog is lost from db.changelog-master.xml, the script still prints OK. I tested this by deleting the module/investor/module-changelog-master.xml line: the result was “OK: 430 parts … each included exactly once”, while 24 investor parts would silently never run. Both the ticket and the script’s own header say the problem is that “Liquibase only sees files reachable from db.changelog-master.xml”. That module list is also a likely place for merge conflicts, since every new module appends a line to it. The fix is small because the script already builds a resolved include table: - start at db.changelog-master.xml and follow the includes, then fail any part that is never reached; or - at minimum, treat every master changelog other than the root like a part, so it must be included somewhere. The <includeAll path="db/custom-changelog"> line can stay ignored, because those files aren’t under db/changelog and don’t need registering. **Some other minor items** - In scripts/check-liquibase-changelog-registration.sh, the comment # ponytail: "../" in an include path is not normalized looks like a leftover. “Note:” was probably meant. - An <include> written with single quotes (file='...') isn’t recognised, so the part is reported as “not included by any master changelog”. That fails safely, but the message is misleading. No changelog in the repo uses single quotes today. - The PR description is the blank template, and the box for tests is ticked although no tests were added. The ticket also still contains a placeholder dev@ list link ([<your thread subject>|<link to your thread>]). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
