DeathGun44 opened a new pull request, #6677: URL: https://github.com/apache/fineract/pull/6677
## Description FINERACT-2888: roadmap row 15 of FINERACT-2609. Moves the bulk import tests (8), the smoke tests (actuator, API docs, Swagger UI, authentication) and four stragglers from REST Assured to the Feign client. Stacked on the row 17 PR (FINERACT-2887), so its commits show here until it merges. - Feign client: a hand-written `BulkImportTemplatesApi` (the generated template operations return `void` and send multipart fields as JSON), and `FineractErrorDecoder` now keeps the body of errors that are not Fineract's envelope (a 401 used to arrive empty). Both covered by unit tests. - Status checks stay as exact as the REST Assured specs were: template upload and downloads pin 200, the actuator pins 200 and a JSON content type, and the error cases pin 401 and 403. - `GET /loanproducts`: five enum options documented `description`, but the server sends `value`. Renamed, so swagger-brake reports R014 for them. - `LoanImportHandlerTest` wrote the collateral product id where the client collateral id belongs; it only passed while both ids matched. Fixed. - Removed the legacy helper code these tests were the last users of, and 13 `restassured-baseline.xml` entries. Left out on purpose: `DateValidationTest` (its invalid interop and fixed deposit dates need schema work first), the share tests (#6448 is migrating that area) and `InteropTest` (#6261 is changing it). Verified on a live server: 16 classes, 22 tests, 18 pass. The 4 others are the unscoped loan and savings template downloads, which return 500 on my long-lived database: `ClientSheetPopulator` throws an NPE on 10 entity clients that older runs left there with an empty display name. They fail the same way with the REST Assured versions, and with the template scoped to one office all 4 import and pass. Static build and quality checks green. ## Checklist - [x] Write the commit message as per our guidelines - [x] Acknowledge that we will not review PRs that are not passing the build - [x] Create/update unit or integration tests for verifying the changes made - [x] Follow our coding conventions - [x] Add required Swagger annotation and update API documentation - [x] This PR must not be a "code dump" - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
