DeathGun44 opened a new pull request, #6676: URL: https://github.com/apache/fineract/pull/6676
## Description FINERACT-2887: roadmap row 17 of FINERACT-2609. Moves the last 16 test classes that used the Retrofit client to Feign, and deletes the Retrofit `IntegrationTest` base. - 13 classes extended `IntegrationTest` (the 11 in `integrationtests/client`, plus `SurveyIntegrationTest` and `ShareAccountCreationValidationTest`). 3 more (`GroupTest`, `InstanceModeIntegrationTest`, `LoanProductShortNameValidationTest`) called Retrofit directly. Every test name is kept. - Feign `ImagesApi` gets multipart `create`/`update` overloads. It could only upload a data URL, which the server handles in a different method, so the image path traversal checks had nothing to call. Covered by WireMock tests. - Feign `RunReportsApi` gets `runReportGetDataWithHttpInfo`, so the report tests still assert 200 as they did with Retrofit. - Error checks assert the exact status: image upload rejections pin 403 `error.msg.document.request.invalid`, and the instance mode rejections pin 405 (before, any exception passed). - `FeignDocumentTest` is removed: the migrated `DocumentTest` makes the same calls with more checks. Verified on develop: the 16 classes on a live server, 122 tests: 120 passed, 0 failed, 2 skipped (the Pentaho and S3 reports, which need those services). Static build (Error Prone), checkstyle, spotbugs and spotless are green. ## Checklist - [x] Write the commit message as per our guidelines - [x] Acknowledge that we will not review PRs that are not passing the build - [x] Create/update unit or integration tests for verifying the changes made - [x] Follow our coding conventions - [ ] Add required Swagger annotation and update API documentation - [x] This PR must not be a "code dump" - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
