jenny1371 opened a new pull request, #6683: URL: https://github.com/apache/fineract/pull/6683
With the database down, every request waited for the connection pool timeout (20 s) and was then answered with a generic HTTP 500. A 500 tells a client that the request itself failed; a 503 with Retry-After tells it that the service is temporarily unavailable and the request can be retried. Map DataAccessResourceFailureException (which includes CannotGetJdbcConnectionException, read requests) and CannotCreateTransactionException (write requests) to HTTP 503 with a Retry-After header and the error code error.msg.database.unavailable. Tests: both mappers answer 503 with Retry-After and a JSON body. The exception mappers added in the previous commit are not reached when the database is down, because the first database access of a request is in TenantAwareBasicAuthenticationFilter (loading the tenant), which runs before the JAX-RS layer. The exception escaped the filter and the container answered HTTP 500 after the 20 s connection pool timeout. Catch DataAccessResourceFailureException and CannotCreateTransactionException in the filter and answer 503 with Retry-After: 5. Tests: both exceptions while loading the tenant give 503 with Retry-After, and the filter chain is not called. ## Description Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
