RusokeMarvin opened a new pull request, #6685:
URL: https://github.com/apache/fineract/pull/6685
## Description
FINERACT-2034: Fix NullPointerException in borrower cycle validation when
counter is null
This PR addresses a logic deadlock in the write-side command validation flow
for loan products using the borrower cycle feature ("Terms vary based on loan
cycle").
### Root Cause
When an application is created for a true first-time borrower with no
historical records in the database, `MAX(l.loan_product_counter)` inside
`LoanReadPlatformServiceImpl.retriveLoanCounter` returns an empty database
result mapping to a Java `null` reference.
Inside `LoanApplicationValidator.validateBorrowerCycle`, this `null`
reference completely overrides the initial `Integer cycleNumber = 0;`
declaration without a null-coalescing check. When passed down into the
`loanProduct.fetchBorrowerCycleVariationsForCycleNumber(cycleNumber)` domain
lookup routine, the system attempts a primitive value unboxing comparison
against user-mandated configuration constraints (such as `equals 1`). This
immediately causes a fatal `java.lang.NullPointerException` and throws a 500
Internal Server Error, locking out all brand-new clients.
### Solution
An explicit null safety check has been introduced right after the
data-access service lookup within `LoanApplicationValidator.java`:
```java
cycleNumber = (fetchedCycle == null) ? 0 : fetchedCycle;
```
This cleanly falls back to a primitive integer `0` for new histories,
resolving the deadlock and allowing successful validation against the global
product parameters without impacting existing client graduation tracking rules.
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [x] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [x] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [x] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [x] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [x] [This PR must not be a \"code
dump\"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [x] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [x] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
