mariiaKraievska commented on PR #6625: URL: https://github.com/apache/fineract/pull/6625#issuecomment-6262628855
> Thanks @mariiaKraievska, this looks much better. `enrichWithStartDates` and `pastDueDays` now go through the same query, the start-date fields are asserted in all 3 scenarios and `delinquentDays > 0` is in. Build is green too. > > Two small things are still left: > > * The 3 new scenarios in `WorkingCapitalDelinquency.feature` (L1357, 1383, 1408) still have no `@TestRailId`. They're the only untagged ones in the file. > * The PR description is still the empty template. Please fill it in before taking it out of draft. > * `WorkingCapitalDelinquency.feature:1442` ends with a whitespace-only line and no final newline (`git diff --check` flags it). > * `delinquencyStartDate` and `overdueSinceDate` now ignore reset periods, periods ending after the business date and periods with no classified delinquent days, where before any period with the check set to false counted. Looks intended and the docs say so, but pls mention it in the description too. > > Once these are done I'm happy to approve. Thanks. > > Recommendation: COMMENT Thanks — remaining items: - @TestRailIds for the 3 new scenarios will be added by QA in a follow-up commit on this PR. @ruzeynalov please correct me, if I`m wrong. - PR description updated. - Trailing whitespace cleaned up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
