AnvayKharb commented on code in PR #6187:
URL: https://github.com/apache/fineract/pull/6187#discussion_r4311168585
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/domain/JdbcSupport.java:
##########
@@ -65,6 +66,18 @@ public static LocalTime getLocalTime(final ResultSet rs,
final String columnName
return localTime;
}
+ public static OffsetTime getOffsetTime(final ResultSet rs, final String
columnName) throws SQLException {
+ try {
+ return rs.getObject(columnName, OffsetTime.class);
+ } catch (SQLException exception) {
Review Comment:
@adamsaghy Thanks for the detailed analysis. I’ve implemented the suggested
approach:
- Store the original clock time as `TIME(6)` and offset separately in
seconds.
- Removed the custom persistence converter and JDBC fallback.
- Updated all read, copy, reversal, transfer, and scheduler paths.
- Added cross-midnight and undo/reversal integration coverage.
- Verified the behavior on PostgreSQL, MySQL, and MariaDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
