SamaSVM commented on PR #6374: URL: https://github.com/apache/fineract/pull/6374#issuecomment-6267225509
> LGTM, thanks for the cleanup. Compile is the real proof here and it is green. > > Non-blocking: `LoanRescheduleModalPeriod` is left orphaned (its only implementation, `LoanRescheduleModelRepaymentPeriod`, is deleted here), delete it in the same PR. Shard 14 is red (`testPostInterestNotZero`, a savings-interest test), which looks unrelated, pls rebase/re-run. The removed repository methods are Spring Data interfaces, so quickly double check nothing resolves them by reflection or SpEL. Thank you. I've deleted `LoanRescheduleModalPeriod` — I somehow missed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
