CaptainAni187 opened a new pull request, #821: URL: https://github.com/apache/fineract-backoffice-ui/pull/821
## What and why The four tables on Campaigns → Email Messages used the element form of the CDK table (`<cdk-table>`, `<cdk-header-cell>`, ...), and the shared styles in `_common.scss` only target `table[cdk-table]`, so the headers ran together as `IDToSubjectStatusActions`. This switches them to `<table cdk-table>` with `<tr>`/`<th>`/`<td>`, the same as the other lists, and does the same for the Survey Responses table, which had the same markup. Also from the issue: each table gets the shared "No records found." row (`*cdkNoDataRow`, same as `app-data-table`), the ID/Status/Actions headers use the `COMMON` keys, the delete button gets an `aria-label`, and the `email-messages` route gets `title: 'EMAIL_MESSAGES.TITLE'`. Closes #744 ## Verification - New tests in `email-messages.component.test.ts`: all four tabs render a native table with a header row and the empty row, the headers are looked up through the translation keys, the delete button has an `aria-label`, and the route has a title. They fail on main. - `npm run test:unit` passes, eslint and prettier are clean. - Checked the page in the browser with the mocked API (same stubs as `e2e/breadcrumb.spec.ts`), screenshots below. ## Screenshots Before:  After:  ## AI assistance (optional) - Tool / model: - Harness / workflow: ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. - [x] I added or updated tests appropriate to this change, or explained why tests were not needed. - [ ] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. (layout fix, no workflow change) - [x] Commits are signed — see [Commit Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md. - [ ] I followed the [AI-assisted contributions guidance](CONTRIBUTING.md#ai-assisted-contributions). - [x] If this adds a feature or changes a workflow, I raised it on [[email protected]](https://lists.apache.org/[email protected]) first — or it is a bug fix, refactor or test change, where that does not apply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
