oleksii-novikov-onix opened a new pull request, #6695: URL: https://github.com/apache/fineract/pull/6695
## Description A full reprocess of a Working Capital loan deleted the charge paid-by rows of all the loan’s transactions, including reversed ones. It then rebuilt them only for the transactions it replays, and reversed transactions are never replayed. Undo and adjust on a loan with an active charge always run the full reprocess. So a reversed repayment, goodwill credit, payout refund or charge adjustment lost the record of which charges it had paid, both in the transactions API and in the Adjust Transaction event. The reprocess now deletes only the rows of non-reversed transactions. A reversed transaction keeps its paid-by rows, the same way an undone term loan transaction does. Tests: e2e scenarios now check that, after undo and adjust, a reversed transaction keeps its paid-by rows: repayment, charge adjustment (fee and penalty), payout refund and goodwill credit. They also check that the rows survive a later backdated repayment and appear in the Adjust Transaction event payload. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
