SamaSVM commented on PR #6382: URL: https://github.com/apache/fineract/pull/6382#issuecomment-6288957257
@galovics Verified the entire repository, not just `fineract-tax`: - **`chargeIncludesTaxParamName`** — no references anywhere in the repository, including Java, SQL, JSON, and integration tests. It was declared but never read. - **`TaxUtils.incomeAmount(..)` and `TaxUtils.addTax(..)`** — neither method has callers outside `TaxUtils` itself, including both `incomeAmount(..)` overloads. The remaining `TaxUtils` consumers (`SavingsAccount`, `SavingsAccountInterestPostingServiceImpl`, `LoanChargeService`, and `ChargeTaxApplicationServiceImpl`) only use `splitTax`, `splitTaxData`, `totalTaxAmount`, and `totalTaxDataAmount`. - **Integration tests** — no references to any of the removed symbols. - **Client modules and API compatibility** — no impact. Both `TaxComponent` and `TaxGroupMappings` have class-level Lombok `@Getter` annotations, making the two removed manual getters redundant. Verified the compiled bytecode using `javap -p`: `getTaxComponentHistories()` and `getTaxGroup()` are still present after the changes. Therefore, the OpenAPI specification and generated client models remain unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
