SamaSVM commented on PR #6383:
URL: https://github.com/apache/fineract/pull/6383#issuecomment-6289140423
@galovics Thank you for reviewing this PR. I've checked all your points:
- **`ChargeTimeType.isAllowedClientChargeTime()`** — confirmed that it is
orphaned and removed it in this PR (`8d707c4`). `isAllowedLoanChargeTime()` is
still in use (`Charge.java:321`), as is `isAllowedSavingsChargeTime()`
(`Charge.java:333`); both are retained.
One important detail: the client-specific method was never actually wired
into the validation flow. `Charge.java:430` validates client charges using
`isAllowedLoanChargeTime()`, not `isAllowedClientChargeTime()`. So this method
wasn't code that became dead; it was never executed. Removing it is still
behaviour-preserving.
**Reference verification:** I went beyond a method-name grep:
1. Searched the entire repository for the symbol across all file types.
2. Checked the Jackson/reflection angle by searching for the bean-property
name `allowedClientChargeTime` across Java, JSON, SQL, Liquibase, feature
files, and documentation. Found zero references. `Charge` is a JPA entity that
is not serialized directly by the API, which uses `ChargeData` instead.
3. Checked for by-name Spring wiring; found none.
- **`ShareAccountChargeWithoutMandatoryFieldException` message keys** — the
key `error.msg.<entity>.<postFix>.cannot.be.blank` is constructed in the
exception's constructor, but the constructor had no call sites. Therefore, the
exception was never instantiated, and the message key was never emitted. I also
searched the repository for both `shareaccount.charge` and
`sharesaccount.charge`; neither had any matches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
