ruzeynalov opened a new pull request, #6699:
URL: https://github.com/apache/fineract/pull/6699

   ## Description
   
   E2E feature files are sharded across CI jobs per file 
(`scripts/split-features.sh`, round-robin by scenario count), so oversized 
files unbalance the shards. This splits every feature file above 50 scenarios, 
following the same convention as the FINERACT-2421 split: the original is 
renamed to `-Part1`, filled to 50 scenarios in original order, the remainder 
moves to the next part, feature-level tags are kept, and the title becomes 
`Feature: <title> - PartN`.
   
   | Before | After |
   |---|---|
   | WorkingCapitalLoanAccount (120) | Part1 50 / Part2 50 / Part3 20 |
   | WorkingCapitalLoanProduct (63) | Part1 50 / Part2 13 |
   | WorkingCapitalDelinquencyReschedule (62) | Part1 50 / Part2 12 |
   | WorkingCapitalLoanChargeOffAccounting (61) | Part1 50 / Part2 11 |
   | LoanReschedule (58) | Part1 50 / Part2 8 |
   | WorkingCapitalDiscount (58) | Part1 50 / Part2 8 |
   | WorkingCapitalNearBreachEvaluation (54) | Part1 50 / Part2 4 |
   | AssetExternalization-Part1 (55) + Part2 (32) | Part1 50 / Part2 37 (last 5 
moved to the top of Part2) |
   
   - Scenario content and order are unchanged, and the `@TestRailId` set is 
identical to develop.
   - `@Order(1)` (WorkingCapitalDelinquencyReschedule) and 
`@SerialChargeAccrualConfig` (WorkingCapitalLoanChargeOffAccounting) are 
carried to every part.
   - `WorkingCapitalNearBreachEvaluation.feature` was the only feature file 
with CRLF line endings; its parts use LF, hence the full-file diff.
   - Cucumber dry-run: 4413 scenarios / 102891 steps, identical to develop.
   - Shard simulation with `split-features.sh` (20 shards): busiest shard 290 → 
236 scenarios, spread 109 → 46.
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [-] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [-] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   - [x] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately.
   - [x] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to