Aarti-panchal01 opened a new pull request, #6701:
URL: https://github.com/apache/fineract/pull/6701

   ## Description
   
   POST /search/advance (the ad-hoc loan search behind the Fund Mapping page) 
returns a 500 on PostgreSQL. The query aliases a column as `'count'` in single 
quotes, which PostgreSQL rejects (`syntax error at or near "'count'"`); MySQL 
and MariaDB accept it. The alias is now unquoted (`a.cnt as count`), which 
works on all three, and the row mapper already reads the column as `count`.
   
   Added a unit test in `SearchReadServiceImplTest` that checks the generated 
SQL has no quoted alias. It fails on develop and passes with this change.
   
   Tested on a local Fineract with PostgreSQL 18: the request returned a 500 
before the change and the grouped loans after it.
   
   JIRA: https://issues.apache.org/jira/browse/FINERACT-2973
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   - [x] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately.
   - [x] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to