Aarti-panchal01 opened a new pull request, #6702:
URL: https://github.com/apache/fineract/pull/6702
## Description
`PUT /hooks/{hookId}` with a new `displayName` or `isActive` returns 200 and
lists them under `changes`, but the hook keeps its old name and active flag
(checked in `m_hook`). `HookWritePlatformServiceImpl.updateHook` adds both to
the changes map but never sets them on the `Hook` entity, unlike events and
config. It also reported both as changed (and saved) when the request left them
out, because it compared null with the stored value.
The hook now gets the new name and active flag when the request provides
them, and they are left alone when it does not.
Added `HookWritePlatformServiceImplTest`: one test renames and deactivates a
hook, one sends neither field. Both fail on develop and pass with this change.
Found while building the Manage Hooks pages of the Mifos X React web app
(MXWAR-235).
JIRA: https://issues.apache.org/jira/browse/FINERACT-2974
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [x] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [x] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [x] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [x] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [x] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [x] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [x] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
