Aarti-panchal01 opened a new pull request, #6705: URL: https://github.com/apache/fineract/pull/6705
## Description `DatabaseSpecificSQLGenerator.castChar` returned `x::CHAR` on PostgreSQL. There `CHAR` with no length is `CHAR(1)`, so the value is cut to its first character (`SELECT 123::CHAR` returns `1` on PostgreSQL 18.3). MySQL's `CAST(x AS CHAR)` has no length limit, so only PostgreSQL is affected. The only use is the code value join for interest rate chart incentives (`m_code_value code on castChar(code.id) = iri.attribute_value`, in `InterestRateChartReadServiceImpl`, `InterestRateChartSlabsReadServiceImpl` and `DepositAccountInterestRateChartReadPlatformServiceImpl`). On PostgreSQL a GENDER / CLIENT_TYPE / CLIENT_CLASSIFICATION incentive pointing at a code value id of 10 or more got no `attributeValueDesc`, and one pointing at a single-digit id matched every code value starting with that digit, so the incentive was returned several times. The PostgreSQL branch now casts to `VARCHAR`, like `groupConcat` in the same class. The MySQL branch is unchanged. Added unit tests in `DatabaseSpecificSQLGeneratorTest` for `castChar` on PostgreSQL, MySQL and an unsupported database. The PostgreSQL one fails on develop and passes with this change. JIRA: https://issues.apache.org/jira/browse/FINERACT-2975 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
