Aarti-panchal01 opened a new pull request, #6709:
URL: https://github.com/apache/fineract/pull/6709
## Description
`PUT /loanproducts/{productId}/productmix` failed with 501 Not Implemented
whenever `restrictedProducts` kept a product that was already restricted, so a
product mix could not be edited (also from the web apps).
`updateProductMix` built the restricted ids with
`Set.copyOf(restrictedProducts)`, which is immutable, and `updateRestrictedIds`
removes the ids it keeps from that set. That threw
`UnsupportedOperationException` (from `ImmutableCollections.remove`), which is
mapped to 501. It came in with the new command processing for product mix
(FINERACT-2256).
The ids are now copied into a `HashSet`, so `updateRestrictedIds` can remove
from it. Nothing else changes.
Added `ProductMixWritePlatformServiceJpaRepositoryImplTest`: product 1
already restricts product 2, and the update keeps 2 and adds 3. It fails on
develop with the same `UnsupportedOperationException` and passes with this
change.
JIRA: https://issues.apache.org/jira/browse/FINERACT-2979
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [x] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [x] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [x] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [x] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [x] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [x] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [x] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
