rymghosn commented on PR #6284:
URL: https://github.com/apache/fineract/pull/6284#issuecomment-6336274564
@adamsaghy Rebased onto the latest `develop` (4725d3ebba).
`MakercheckerTest` had moved to Feign, so I rewrote the savings-account test on
the Feign helpers. On the scope gap, I reproduced both ticket scenarios on
current `develop` against PostgreSQL, with maker-checker enabled globally and
for `DISBURSE_LOAN`:
- **Scenario 1 (a checker can't approve without the operational
permission):** it doesn't reproduce. A user holding only
`DISBURSE_LOAN_CHECKER` approves a maker's queued disbursement through `POST
/makercheckers/{id}?command=approve`, and the loan becomes active.
`approveEntry` checks the `_CHECKER` permission, and the base permission is
only checked when a command is first submitted.
- **Scenario 2 (actions bypass the pending queue):** a regular maker's
disbursement is queued, and `GET /makercheckers?loanid=<id>` lists it. It's
applied immediately only for a checker super user, and
`AppUser#hasPermissionTo` gives every code, including `CHECKER_SUPER_USER`, to
anyone holding `ALL_FUNCTIONS`. So an admin's direct disbursement is the
designed super-user auto-approval, not a missing check. Changing what
`ALL_FUNCTIONS` implies would affect every deployment, so I haven't touched it
here. I'll put it on the dev list together with the broader question you raised.
I added `MakerCheckerLoanDisbursementTest` to pin both behaviours: queued,
listed by loan and approved by a checker-only user, and a super user's
disbursement applied immediately. The ticket's remaining symptom, "the request
may not appear in the Checker Inbox", is the savings-account filter gap this PR
fixes. `testPendingSavingsAccountUpdateIsFoundBySavingsAccountId` fails on
`develop` (0 entries) and passes with the change. The whole `MakercheckerTest`
class and the new test pass. I've updated the description to match. Could you
please re-review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
