rhopman commented on PR #6460: URL: https://github.com/apache/fineract/pull/6460#issuecomment-6338273296
Thanks for the review, @adamsaghy ! I pushed a new commit: - **Fatal-error context:** the aggregate `JobExecutionException` now includes charge ID, savings account ID, installment due date, and failure reason in its message. Original exceptions remain unchanged in `getCauses()`, avoiding the earlier wrapper concern. - **Validation coverage:** added explicit fatal-validation tests, including a failure after an earlier successful installment. Tests verify the context survives Spring Batch exit-status serialization. - **Minimum-balance and held-funds shortfalls:** these are now treated as skips when every validation error matches the exact savings pay-charge balance-shortfall code. The skip count increments and unrelated charges continue. Mixed or unrelated validation errors remain fatal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
