rhopman commented on PR #6500: URL: https://github.com/apache/fineract/pull/6500#issuecomment-6340586963
Thank you @adamsaghy for identifying the `overdraftAmount` mismatch. I added the same `!transaction.isAmountOnHold()` guard to the DTO fallback, keeping the scheduled interest-posting path consistent with the entity path. I also added an interest-bearing regression test that: - withdraws an account to a negative ledger balance; - places a hold within the overdraft limit; - runs Post Interest For Savings; - verifies the original hold remains unreversed; - verifies its running balance remains equal to the ledger balance; - verifies it carries no overdraft amount. The regression test failed before the fix because the job reversed the original hold, and passes after the fix. I have also updated the PR description to disclose the interest-calculation effect: for a day ending with a hold, interest is now calculated using the ledger balance rather than the ledger balance minus the held amount. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
