galovics opened a new pull request, #6724: URL: https://github.com/apache/fineract/pull/6724
LoanReadPlatformServiceImpl's floating-rate-change selection queries filtered on m_floating_rates_periods.created_date, but FloatingRatePeriod extends AbstractAuditableWithUTCDateTimeCustom, which populates created_on_utc via JPA auditing and never writes created_date (its NOT NULL constraint was dropped in migration 0024, changeset floating-rate-period-5). Since created_date is always NULL, "created_date >= ?" never matched, so loans affected by a new or changed floating rate period were never selected for interest recalculation. Filter on created_on_utc instead. Since created_on_utc is a UTC timestamp, bind the tenant's actual start-of-day boundary (DateUtils.getOffsetDateTimeOfTenantFromLocalDate) rather than a bare LocalDate - binding a bare date would have the DB interpret it at midnight in its own session time zone rather than the tenant's, which for a tenant ahead of UTC could still miss a rate period created early in its local day. Assisted-By: Claude Code-Sonnet-5 ## Description Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
