alberto-art3ch opened a new pull request, #6727:
URL: https://github.com/apache/fineract/pull/6727
## Description
## Problem
`ExecuteStandingInstructionsTasklet#transferAmount` builds the INSERT into
`m_account_transfer_standing_instructions_history` by string concatenation:
(a) a failed transfer whose exception message contains a quote breaks the
statement;
(b) a message longer than the 500 characters of `error_log` fails with
"value too long" (PostgreSQL, MariaDB strict mode);
(c) the amount is written from `doubleValue()` instead of the original
`BigDecimal`.
In every case the exception escapes the loop in `execute()`, so the
remaining instructions of the run are not processed.
## Change
- One `jdbcTemplate.update` with `?` placeholders for
`standing_instruction_id`, `status`, `amount` and `error_log`. `execution_time`
stays `now()` and the column name keeps `sqlGenerator.escape("status")`.
- Amount bound as `BigDecimal`.
- `error_log` truncated to the column size on failure; a successful run
still stores `''`, so the run-history API response does not change.
- Catch blocks and messages untouched.
## Tests
- New `ExecuteStandingInstructionsTaskletTest`: message with a quote is
bound as-is, message longer than the column is truncated, successful transfer
records `success` with the exact amount and updates `last_run_date`.
- New
`SchedulerJobsTestResults#testExecuteStandingInstructionsJobRecordsFailedTransferInHistory`:
one instruction without balance and one with balance in the same run; asserts
the `failed` row with its error log, the `success` row and the balances. Two
minimal helpers added (`SchedulerJobHelper#executeAndAwaitJobStatus`,
`StandingInstructionsHelper#deleteStandingInstruction`).
- Local: spotless, compileJava/compileTestJava, unit tests, checkstyle,
modernizer, spotbugs green.
## Transaction behaviour of a failed run
<completar con el resultado de la IT: si la instrucción exitosa persiste
junto a la fallida, o si el step revierte la corrida entera. Si revierte,
decirlo como comportamiento preexistente fuera de este PR.>
## Out of scope
`DatabaseSpecificSQLGenerator#formatValue` (values come from the
`EntityTables` enum). Separate finding: the transfer description is built as
`name + " Standing instruction trasfer "` and can exceed
`m_account_transfer_transaction.description` VARCHAR(200) for long instruction
names.
[FINERACT-2968](https://issues.apache.org/jira/browse/FINERACT-2968)
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
- [ ] I followed the [AI
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
