zhangxinyao88 opened a new pull request, #831:
URL: https://github.com/apache/fineract-backoffice-ui/pull/831

   ## What and why
   
   Create Loan now shows “Not set” for an empty Repayments Starting From Date 
instead of displaying today. A clear action restores the empty value, and a 
retry after a rejected create no longer sends a stale date that the user 
cleared.
   
   Related to #793: this fixes its optional-date portion. Required markers and 
disabled-Save feedback remain open. Existing-record editing, date formatting 
and repayment calculations/defaults are unchanged.
   
   ## Verification
   
   - 315 files / 2599 application unit tests passed in each of UTC and 
America/New_York; 2 microfrontend tests passed.
   - The final 5-test regression suite fails 3 cases on untouched main and 
passes on this patch, using mocked HTTP and Angular form controls.
   - 2 mocked browser tests passed with no retries at desktop 1280px and phone 
390px: unset/open-dismiss/select/clear, rejected-create retry, exact 
date/omitted field, and revisit.
   - Production build, lint/format, translations/icons/a11y/template/UI checks, 
E2E types, API surface, license and GA passed. Existing lint/style-budget 
warnings and the GA adapter advisory remain.
   - No live backend used.
   
   ## Screenshots
   
   The added spec saves focused selected/unset date-field screenshots and page 
screenshots/video in Playwright's output directory. Desktop and phone captures 
were inspected locally using synthetic fixtures.
   
   ## AI assistance (optional)
   
   Codex assisted with implementation and synthetic Vitest/Playwright 
verification.
   
   ## Checklist
   
   - [x] No generated files were hand-edited; no new generated-client import 
was added.
   - [x] The new control uses the app-owned UI boundary; user-facing strings 
use translation keys.
   - [x] Focused regression and suitable mocked e2e coverage are included.
   - [x] Commits are signed.
   - [x] AI-assisted contribution guidance followed.
   - [x] This is a bounded bug fix, not a new feature/design proposal.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to