[ 
https://issues.apache.org/jira/browse/FINERACT-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18131296#comment-18131296
 ] 

Sonigra Bhavya Hemendrabhai commented on FINERACT-2986:
-------------------------------------------------------

_Hi [~adamsaghy], I pulled the latest {{develop}} branch and noticed that PR 
#6691 (commit {{313c6a70e0}} / {{{}09e387371a{}}}) already implemented 
case-insensitive matching, canonical storage on PUT, 
{{{}pl-charge-accrual-time{}}}, and documentation for all restricted global 
configuration values._

_I tested this on the latest build (e.g. updating with {{{}EOD{}}}, 
{{{}SUBMITTED-DATE{}}}, and {{{}asset,liability{}}}), and everything normalizes 
and resolves as expected. Should we close this issue as resolved by PR #6691, 
or is there any remaining piece you'd like me to look into?_

> Make global configuration values case insensitive
> -------------------------------------------------
>
>                 Key: FINERACT-2986
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2986
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: 1.16.0
>            Reporter: Adam Saghy
>            Assignee: Sonigra Bhavya Hemendrabhai
>            Priority: Major
>              Labels: beginner, beginner-friendly
>             Fix For: 1.17.0
>
>
> Global configurations with a fixed set of allowed {{{}stringValue{}}}s (such 
> as {{{}charge-accrual-date{}}}, {{pl-charge-accrual-time}} and 
> {{{}account-mapping-for-payment-type{}}}) are currently validated and 
> resolved with case-sensitive matching. So a value like {{EOD}} or {{asset}} 
> is rejected, or doesn’t resolve to its matching option, even though it 
> clearly means {{eod}} or {{{}Asset{}}}. This story makes both validating and 
> reading these values case-insensitive, stores each value in its canonical 
> form, and updates the allowed-values documentation to match.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to