oleksii-novikov-onix opened a new pull request, #6743: URL: https://github.com/apache/fineract/pull/6743
## Description Previously, the retained earning writer checked for existing annual summary entries in beforeStep and skipped persistence when entries were found. However, the summary step still ran, fetching and processing the trial balance reports. This change moves that check into a job execution decider before the summary step. If any annual summary entry exists for the calculated fiscal year end date, the flow ends without running the step, skipping both the loan and working capital loan trial balance reports. The job listener calculates the fiscal year end date once per execution and stores it in the job execution context for the decider and reader. The repository check now returns a boolean using a COUNT query instead of loading all matching entities. The change adds unit tests for both decider outcomes and updates the affected component tests. The existing year-end close E2E scenario adds an assertion expecting exit code NOOP after a repeated run. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
