airajena commented on code in PR #102: URL: https://github.com/apache/fineract-business-intelligence/pull/102#discussion_r4380537457
########## controlplane/db.py: ########## @@ -0,0 +1,116 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + + +from __future__ import annotations + +import os +import ssl +from collections.abc import Iterator +from contextlib import contextmanager +from dataclasses import dataclass + +import pg8000.dbapi + + +@dataclass(frozen=True) +class PgConfig: + host: str + port: int + database: str + user: str + password: str + ssl_mode: str = "disable" + application_name: str = "fbi-controlplane" + timeout: float | None = None + + def connect_kwargs(self) -> dict: + kwargs = { + "host": self.host, + "port": self.port, + "database": self.database, + "user": self.user, + "password": self.password, + "application_name": self.application_name, + } + if self.timeout: + kwargs["timeout"] = self.timeout Review Comment: Fixed. The timeout now applies only while connecting; after the connection is established the socket timeout is cleared. Long queries are limited server-side with statement_timeout (FBI_SOURCE_STATEMENT_TIMEOUT_SECONDS, default 30 minutes), and TCP keepalive is tuned to detect dead peers. There's a test showing a query longer than the connect timeout completes and one past the statement timeout is cancelled with 57014. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
