Aana123 opened a new pull request, #222: URL: https://github.com/apache/fineract-consumer-facing/pull/222
## What and why Migrates the auth screens behind the I18N adapter boundary, following "How to migrate a component" in #172. This supersedes #199, which was closed for inactivity. These were the last three entries in `eslint-suppressions.json`, so the baseline is now empty and #172 is complete. - `login.component.ts`, `forgot-password.component.ts`: `TranslatePipe` now comes from `core/adapters` (merged into the existing `OVERLAY` import in forgot-password); every `| translate` is now `| appTranslate` (7 + 9 usages). - `forgot-password.component.spec.ts`: `provideTranslateService()` replaced with `...provideI18nTesting()`. - `eslint-suppressions.json`: pruned with `npm run lint:prune`, now an empty object. Committed exactly as the prune writes it, without reformatting. The `I18nService.translate()` calls are untouched, since that's application code, not the library import. One login template line was re-wrapped by Prettier because the longer pipe name pushed it past the print width; whitespace only. No behaviour change. Closes #174 ## Verification - `npm run lint`: passes - `npm run i18n:check`: passes - `npx prettier --check` on the three source files: clean - `npm test -- --no-watch`: 24 test files, 144 tests passed, including the migrated `ForgotPasswordComponent` suite - `npm run build`: passes - Manually checked the login and forgot-password pages render translated text ## Screenshots Not applicable (no visual change). ## AI assistance (optional) - Tool / model: Claude Code - Harness / workflow: drafted the edits from a written spec; I reviewed the full diff, ran the checks above, and confirmed the usage counts. ## Checklist - [x] I did not hand-edit generated files under `frontend/src/openapi-client/`. - [x] Frontend code goes through the adapters in `frontend/src/app/core/adapters/`. - [x] I did not add entries to a lint or architecture baseline (this PR only removes them). - [x] User-facing strings use translation keys. (Keys unchanged.) - [x] I added or updated tests appropriate to this change. (Spec provider migrated; no new behaviour to test.) - [x] UI workflow changes include suitable e2e coverage. (No workflow change.) - [x] Commits are signed. - [x] I followed the AI-assisted contributions guidance. - [x] Refactor only; no dev-list discussion needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
