alberto-art3ch opened a new pull request, #6751:
URL: https://github.com/apache/fineract/pull/6751

   ## Description
   
   The WC COB worker built its reader, processor and writer with `new` inside 
the singleton step bean, so one instance served every partition; the reader 
keeps the partition's loan ids in an instance field, and concurrent partitions 
overwrote each other's queue. One partition then read nothing, finished 
COMPLETED and left its loan a day behind with a stale LOAN_COB_CHUNK_PROCESSING 
lock, with no error logged.
   
   This declares the three components as `@StepScope` beans returning their 
concrete classes (so `@BeforeStep` is still detected), mirroring 
`LoanCOBWorkerConfiguration`, and adds a test that guards the scope. Verified 
with a single tenant, 4 WC loans and partition size 1 over 5 COB days: develop 
left 2 of 4 loans behind, this branch processed 4 of 4 with no stale locks.
   
   [FINERACT-2995](https://issues.apache.org/jira/browse/FINERACT-2995)
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [ ] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [ ] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [ ] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately.
   - [ ] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to