Ashutosh-Panda2004 commented on PR #6614: URL: https://github.com/apache/fineract/pull/6614#issuecomment-6469246992
@adamsaghy You are right, sorry about that. The mapper still called the old 4-argument TaxGroupMappingsData constructor. It now passes componentEditable the way develop's own TaxGroupMappingsMapper leaves it, as null, since the flag is only set later in the tax group template flow and nothing in the interest posting path reads it. The mapper change now has tests in SavingsAccountReadPlatformServiceImplTest: one for the new tax group joins in the SQL, and one that runs the extractor over two result rows and checks the loaded tax group, its mapping, component and history. The existing product mapping test also needed apm6 added to its alias list. The branch is rebased on the current develop in a single signed commit. CI will be the first full compile on my side, so please let me know if anything else comes up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
