KRYSTALM7 commented on code in PR #173: URL: https://github.com/apache/fineract-loan-origination/pull/173#discussion_r4404062855
########## src/main/resources/META-INF/licenses/SecLists-SOURCE.txt: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +Resource: common-passwords.txt Review Comment: Thanks for highlighting the licensing concern. Given the uncertainty around the licensing of the underlying NCSC password compilation and its redistribution, let's avoid bundling this third-party wordlist in the LOS repository. I'll update issue #138 to remove the bundled common-password blocklist requirement. Please remove `common-passwords.txt`, its SecLists license/provenance files, and the associated resource-loading and blocklist-validation logic. Keep the minimum password length and username/email validation, along with the existing tests for those rules. Please also remove the related RAT exclusions and Maven configuration changes that were added solely for this resource. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
