zhangxinyao88 opened a new pull request, #841:
URL: https://github.com/apache/fineract-backoffice-ui/pull/841

   ## What and why
   
   Editing a family member shows today on the Date of Birth button, even when a 
different DOB is saved or no DOB exists. Bind the loaded date to the picker and 
show “Not set” for an absent value. The picker uses a local timestamp so 
selecting another day does not shift the submitted date west of UTC.
   
   The existing update payload is preserved: an unchanged saved DOB is still 
sent in its existing format, and an absent DOB stays omitted. Create-mode 
selection, clearing and retry behavior are unchanged. This does not add 
clearing of a persisted DOB.
   
   Follow-up to #747 and the [edit-mode request on merged 
#829](https://github.com/apache/fineract-backoffice-ui/pull/829#discussion_r4385329127).
 No change to the client-details work in #839 or the broader clear-DOB 
follow-up.
   
   ## Verification
   
   - Four focused assertions fail against the original implementation; all 10 
focused tests pass with the fix. Covers actual member loading, 
saved/absent/null values, unchanged PUT and explicit replacement.
   - Full unit suite: 317 files / 2,638 tests passed separately in UTC and 
America/New_York; 2 MFE tests passed.
   - Affected mocked Playwright spec: 4 passed, zero retries, at 1280px and 
390px. Checks loaded calendar selection, open/cancel, unchanged save, 
replacement date, unset save, and existing create/clear/retry flows.
   - Clean `npm ci`, lint, format, translations, icons, accessibility names, 
template/UI checks, e2e typecheck, API surface, license, production audit and 
build passed. GA: 10/11 with the existing adapter advisory, zero blocking or 
undetermined gates. Existing lint/style-budget warnings remain; no suppressions 
or dependencies changed.
   - Local tooling: Angular's supported SQLite cache backend avoided a native 
LMDB crash; the isolated dev server used polling. These are process-local 
settings, outside the patch. Browser responses were synthetic; no real-backend 
runtime or full browser suite was run.
   
   ## Screenshots
   
   Synthetic fixtures from the passing browser run. Images are on a fork-only 
review branch outside this PR’s code diff.
   
   | | Saved DOB | Unset DOB |
   |---|---|---|
   | Desktop | ![Desktop saved 
DOB](https://raw.githubusercontent.com/zhangxinyao88/fineract-backoffice-ui/8b5eec9852d306cb00023faf59cd0245904f2edb/review/family-edit-dob/desktop-stored.png)
 | ![Desktop unset 
DOB](https://raw.githubusercontent.com/zhangxinyao88/fineract-backoffice-ui/8b5eec9852d306cb00023faf59cd0245904f2edb/review/family-edit-dob/desktop-unset.png)
 |
   | Mobile | ![Mobile saved 
DOB](https://raw.githubusercontent.com/zhangxinyao88/fineract-backoffice-ui/8b5eec9852d306cb00023faf59cd0245904f2edb/review/family-edit-dob/mobile-stored.png)
 | ![Mobile unset 
DOB](https://raw.githubusercontent.com/zhangxinyao88/fineract-backoffice-ui/8b5eec9852d306cb00023faf59cd0245904f2edb/review/family-edit-dob/mobile-unset.png)
 |
   
   ## AI assistance
   
   OpenAI Codex, using the Follow-up Contribution workflow. Inspected the 
maintainer request and current source, added regression tests and ran the 
checks above.
   
   ## Checklist
   
   - [x] No hand-edited generated API files or new dependencies.
   - [x] Uses the existing incoming-date adapter and translated strings.
   - [x] Unit and browser regression coverage added; mocked/backend boundary 
stated.
   - [x] Commits signed with the existing contributor signing key.
   - [x] AI-assisted contribution guidance followed.
   - [x] Bug fix and regression coverage; new-feature mailing-list discussion 
does not apply.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to