adamsaghy commented on PR #6698: URL: https://github.com/apache/fineract/pull/6698#issuecomment-6482106245
> Thanks @adamsaghy for the review, all three findings were valid. I've pushed fixes: > > **1. Collection sheet:** `mandatorySavingsAccountDeposit` now uses a scoped loader. The savings loop swallowed every exception, so the check fired but the request still returned 200. It now re-throws only `NoAuthorizationException`, giving a 403 like the loan part of the same sheet. Other errors behave as before. > > **2. FD/RD:** deposit, withdrawal, post interest, undo, adjust, close and premature close now check the account's office. > > **3. Undo disbursal:** internal transfer reversals (`allowAccountTransferModification = true`) no longer re-check the counterparty account, because the loan that triggered them is already checked. The user-facing transfer undo now checks both sides, matching create. > > **Tests:** integration tests for all three, plus a regression test where undo-disbursal succeeds with a transfer from another branch's savings account. > > **Not covered in this PR** - account activation (savings/FD/RD), capitalized income, buy-down fee, re-age/re-amortize, interest pause, contract termination, and working-capital loans. and cross-branch transfers now need access to both offices. Happy to open a follow-up JIRA for these and work on it next. Please do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
