adamsaghy commented on PR #6759: URL: https://github.com/apache/fineract/pull/6759#issuecomment-6483700225
Thanks, the switch looks complete: I count the 52 reads, and the only US-locale amount reads left are the breach and near-breach configuration validators you call out. There is a second behaviour change here that the description doesn't mention, and it can break existing clients. A **text** amount sent **without a `locale`** is now refused with `validation.msg.missing.locale.parameter`, because `JsonParserHelper.convertFrom` requires a locale for string values. Before this PR the US-locale read accepted it. Examples: - a near-breach action with `"nearBreachThreshold": "50"` and no `locale` - a discount fee with a text `transactionAmount` and no `transactionDate`/`locale` Requests that carry a date already need a locale, and JSON numbers are unaffected, so the impact is limited to text amounts on date-less requests. It's still a breaking API change, though. Question: is this intended? If yes, could you add it to the behaviour-change note (and the JIRA), so it can be called out in the release notes? If not, should a text amount with no locale fall back to the previous behaviour for these requests? Also, could you re-run E2E shard 1? The UC40 failure is the status-changed event check matching the earlier CLOSED event, which doesn't look related to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
