adamsaghy commented on PR #6426:
URL: https://github.com/apache/fineract/pull/6426#issuecomment-6502335502
Thanks @SamaSVM, all three points are addressed: the test is on Feign and CI
is green, the calculation type is snapshotted and carried through both the job
and COB paths, and the backfill covers all statuses. Two small follow-ups,
neither blocking:
1. The 1037 backfill now runs one unbatched `UPDATE` over all of `m_loan`
again (the lock concern from the first review comes back with the wider scope).
Please mention this in the description so operators of large tenants know to
expect it.
2. The changeset comment says lowest-id selection is consistent with
`LoanProduct#getOverdueInstallmentCharge()`, but `LoanProduct.charges` has no
`@OrderBy`, so `findFirst()` isn't guaranteed to agree. Either add
`@OrderBy("id")` / sort by id, or drop that sentence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
