Abda11ah255 commented on PR #6722: URL: https://github.com/apache/fineract/pull/6722#issuecomment-6535145518
Hi @galovics, thank you for the review — you are completely right. The read APIs serialize TaxGroupData and TaxComponentData, not the JPA entities, and my apologies for pushing before running :fineract-tax:test and spotlessJavaApply locally. I dug into git log on the DTOs and API classes to see why I couldn't reproduce the missing getters or spelling mismatch on develop, and realized that the issue described in FINERACT-2351 was already resolved under another ticket: Commit d61bbeb71a (FINERACT-2169) refactored TaxGroupApiResource / TaxComponentApiResource and introduced the creditAcountId / debitAcount spelling mismatch and DTO serialization issue described in FINERACT-2351. Commit b7306f19d0 (FINERACT-2425: Tax component and Tax Group refactoring) already fixed the debitAccountId / creditAccountId spelling mismatch across TaxComponentRequest, TaxComponentData, TaxApiConstants, and TaxValidator, and added TaxesTest.java, while @Getter is already present on TaxGroupData, TaxGroupMappingsData, and TaxComponentData. Because FINERACT-2351 was still left Open on Jira after FINERACT-2425 was merged, I mistakenly looked at the JPA entities (TaxGroup and TaxComponent) when I saw the DTOs already had their getters and corrected field names on develop. The only leftover typo I see in the API class is the method name updateTaxCompoent in TaxComponentApiResource.java. Would you like me to close this PR and mark FINERACT-2351 as already resolved by FINERACT-2425 on Jira, or is there anything remaining here you'd like me to address? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
