Samer-Melhem-FOO commented on PR #6528: URL: https://github.com/apache/fineract/pull/6528#issuecomment-6518702413
@adamsaghy thanks, you were right about the history path. Fixed in 9574db6a22: - `generateRecurringDates` now starts from an empty list and skips any calendar or history row that yields no dates, so neither an edited non-repeating calendar nor a calendar switched from non-repeating to repeating hits `addAll` on/with `null`. - Unit tests in `CalendarReadPlatformServiceImplTest` for both cases (both reproduced the NPEs before the change). - New `CalendarNonRepeatingIntegrationTest`: creates a non-repeating group calendar, edits its title, and reads it back through the endpoint. Verified on a local boot: on the previous head, after a title edit the single calendar, the group's calendar list and the jlgbulk loan template all returned 500; with this commit all three return 200 and the integration test passes. I also aligned the JIRA wording (`repeatsOnNthDayOfMonth` comes back as `nthDayType.invalid`) and added the edit case there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
