[
https://issues.apache.org/jira/browse/FLEX-33865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812420#comment-13812420
]
Maurice Amsellem commented on FLEX-33865:
-----------------------------------------
Benoit, I have reviewed the patch and had some remarks:
1) your test to trim spaces should use isWhiteSpace intead of == " "
2) Test with Number is actually slower than the original because of the manual
Array construction and the as operator
when result is null, it's faster to return [ X , Y ] ;
3) the main case (" abc: NN") is more 4x times than 6x on my own tests, but
it's already very good. ( Tested with Chrome / FP 11.9 on Win7)
Also, keep in mind that local optimization on functions that are already very
fast, and that are not called very often,
may only have a small impact on the OVERALL application performance.
Although you cannot share your mobile app, do you have any idea, even
subjective, on the actual performance gain when applying this optimization to
the mobile app?
PS: I understand and appreciate that you already spent a lot of time on this
issue (and so did I :-) ), so I will try to conclude this issue as soon as
possible...
> ConstraintLayout / LayoutElementHelper are memory inefficient (and slow)
> ------------------------------------------------------------------------
>
> Key: FLEX-33865
> URL: https://issues.apache.org/jira/browse/FLEX-33865
> Project: Apache Flex
> Issue Type: Improvement
> Components: Mobile: Performance, Spark: Layout
> Affects Versions: Apache Flex 4.11.0
> Environment: mobile desktop
> Reporter: Benoit Wiart
> Assignee: Maurice Amsellem
> Labels: mobile, performance
> Attachments: 0001-ConstraintLayout-optimizationsV2.patch,
> layout-1-desktop-memory.png, layout-2-desktop-memory.png
>
>
> ConstraintLayout / LayoutElementHelper are doing too many memory allocation.
> it's really bad on mobile
> the attached screenshots were taken on desktop
--
This message was sent by Atlassian JIRA
(v6.1#6144)
